store: fix Windows path separator issue when loading blocks from object storage #8613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace filepath.Join with path.Join for constructing object storage paths to fix issue thanos-io#8361 where Thanos fails to load blocks from MinIO on Windows. filepath.Join uses OS-specific path separators (backslash on Windows), but object storage systems require forward slashes in object keys. path.Join always uses forward slashes regardless of OS. Changes: - pkg/block/indexheader/binary_reader.go: Use path.Join for index path - pkg/compact/planner.go: Use path.Join for bucket attribute calls Fixes thanos-io#8361 Signed-off-by: Gauarv Chaudhary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace filepath.Join with path.Join for constructing object storage paths to fix issue #8361 where Thanos fails to load blocks from MinIO on Windows.
filepath.Join uses OS-specific path separators (backslash on Windows), but object storage systems require forward slashes in object keys. path.Join always uses forward slashes regardless of OS.
Fixes #8361
Changes
filepath.Joinwithpath.Joinfor index path construction passed to bucket operationsfilepath.Joinwithpath.Joinfor bucket attribute path constructionVerification
make formatsuccessfullygo build ./pkg/block/indexheader/... ./pkg/compact/...successfullymake buildsuccessfullyfilepath.Join