receive: only start CapNProto server when explicitly configured #8616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CapNProto server was starting unconditionally even when using the default Protobuf protocol. This caused port conflicts when running multiple receiver instances locally and wasted resources. Changes: - Check --receive.replication-protocol flag before starting CapNProto server - Only start when explicitly set to 'capnproto' - Add informative log messages for both enabled and disabled states Fixes thanos-io#8093 Signed-off-by: Gaurav Chaudhary <[email protected]> Signed-off-by: Gauarv Chaudhary <[email protected]>
fpetkovski
reviewed
Jan 1, 2026
Contributor
fpetkovski
left a comment
fpetkovski
left a comment
There was a problem hiding this comment.
I can see how starting the capnproto server can be a problem, but this flag is really intended for the router, not the receiver. So if we now merge this PR, existing deployments could break since we are changing default behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CapNProto server was starting unconditionally even when using the default Protobuf protocol. This caused port conflicts when running multiple receiver instances locally and wasted resources.
Fixes #8093
Changes
--receive.replication-protocol=capnprotoVerification
make buildpassesgo vet ./cmd/thanos/...passesmake formatpasses