Bug: Compactor lists blocks with marks as partial

[waltherlee]

A recent change (#8389) in fetcher.go makes the compactor list as partial any block with marks, like no-compact or no-delete, when using a recursive discovery strategy.

In the previous implementation, the compactor used to run the following checks:

for id, _ := range blocks {
    for _, file := range blocks[id] {
        if _, ok := partialBlocks[id]; !ok {
            partialBlocks[id] = true
        }
        if IsBlockMetaFile {
            partialBlocks[id] = false
        }
    }
}

In the current one:

for id, _ := range blocks {
    for _, file := range blocks[id] {
        if _, ok := partialBlocks[id]; !ok {
            partialBlocks[id] = true
        }
        if IsBlockMetaFile {
           delete(partialBlocks, id)
        }
    }
}

If the bucket iterator returns any file after meta.json, like no-compact-mark.json, partialBlocks[id] will be empty and set to true, even though a meta.json has been already found for the block.

Changes

I'm changing the line back to partialBlocks[id] = false

Verification

Added a small test to replicate the error.

[GiedriusS]

Thank you 🙇