Init thanos_status metrics on startup#8758
Open
prymitive wants to merge 1 commit intothanos-io:mainfrom
Open
Conversation
thanos_status metrics are not being reported until the metric is set to 1 when the server starts. This is fine for services that start quickly, but for Thanos Receive we replay the WAL on startup during which server isn't ready but we don't have the thanos_status metric until it's ready. Fix it by setting the metric to 0 when it's created, so it's exported instantly. Signed-off-by: Lukasz Mierzwa <lukasz@cloudflare.com>
MichaHoffmann
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thanos_status metrics are not being reported until the metric is set to 1 when the server starts. This is fine for services that start quickly, but for Thanos Receive we replay the WAL on startup during which server isn't ready but we don't have the thanos_status metric until it's ready. Fix it by setting the metric to 0 when it's created, so it's exported instantly.
Changes
Verification