receiver: ignore lost+found directory during tenant discovery - #8800
Closed
NamanKu-tech wants to merge 2 commits into
Closed
receiver: ignore lost+found directory during tenant discovery#8800NamanKu-tech wants to merge 2 commits into
NamanKu-tech wants to merge 2 commits into
Conversation
The receiver would treat the lost+found directory as a tenant when scanning the tsdb.path, causing it to create TSDB files and logs for it. This directory should be skipped like other non-tenant directories. Fixes: thanos-io#8798 Signed-off-by: NamanKu-tech
Adds a unit test to verify that the lost+found directory is successfully ignored during tenant discovery in MultiTSDB.Open(). Signed-off-by: NamanKu-tech
Member
|
Fixed in another PR. Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8798
What changed
The receiver now ignores the
lost+founddirectory when scanning for tenants. Previously, it would treat this directory as a tenant and create TSDB files within it, which is incorrect.Changes made:
MultiTSDB.Open()to skip thelost+founddirectoryMultiTSDB.RemoveLockFilesIfAny()to skip thelost+founddirectoryTestMultiTSDBIgnoresLostFoundDirectoryto verify the fixTesting