Draft
Conversation
thatcomputerguy0101
force-pushed
the
trixie
branch
3 times, most recently
from
f54014b to
3a1bfb3
Compare
This significantly speeds up the build of the Rubik Pi image.
thatcomputerguy0101
force-pushed
the
trixie
branch
from
3a1bfb3 to
8295552
Compare
Utilize the [photon-image-runner](https://github.com/PhotonVision/photon-image-runner) action to build images. Once this is validated, we can use the same action for modifying the images in [photonvision](https://github.com/PhotonVision/photonvision) and [photon-libcamera-gl-driver](https://github.com/PhotonVision/photon-libcamera-gl-driver) workflows. Improvements in this PR: * Like PhotonVision#95, this uses the GitHub arm runner to greatly speed up image build times. * Images specified by a yaml file, like the RubikPi3, are handled correctly. * A PhotonVision release can be specified in the workflow, which allows images to be built with releases other than latest. * The action implements an option to specify the minimum free space needed in the image. This should prevent repeated increases in the size of an image if it can't be shrunk by the action. * Several minor problems were fixed, including * CIDATA partition is properly mounted on OrangePi * Version information is added by `install_common.sh` * Empty space is zero filled on all images for better compression * No more log spam from Dpkg Supersedes PhotonVision#95
PhotonVision#97 included a "dummy" rubikpi3 job to satisfy the required check. The check has been removed, so it is no longer needed.
This PR corrects a typo in PhotonVision#97.
Update the hostname to 'photonvision' so that RaspberryPi-based systems boot with the right hostname. Closes PhotonVision#89
photon-image-runner v1.2.0 has been updated to properly mount the /boot partition. This PR will write CIDATA files to this location on OPi5 images. By using the updated runner, this also corrects a problem with the config.txt file not being copied to the correct location on RaspberryPi-based images.
Corresponding to PhotonVision/photonvision#2171, this removes the now-unused `pigpio` dependency from the installation scripts. closes PhotonVision#63
PV tries to access networking information fairly early in the startup process and, when NetworkManager isn't ready, PV cannot get the information it needs about the network hardware. This PR configures the photonvision service to start after NetworkManager is running. The change is only made when PV is configured to manage networking. This should reduce the need for PhotonVision/photonvision#2240, but it's safer to have both.
This PR updates the action to make sure that it fails when there is an error in the install script. It also adds missing package repos for the RubikPi image.
The standard fan control for the RubikPi3 isn't aggressive enough at turning on the fan. This changes our image so that the fan runs continuously at max speed.
thatcomputerguy0101
force-pushed
the
trixie
branch
from
8295552 to
e4c78c8
Compare
Raspberry Pi OS's prior to Bookworm would mount partition 1 as /boot. This is the default behavior for the arm-runner-action that we were using to create images and this behavior was copied in the photon-image-runner that we now use. However, mounting this partition as /boot shadows the real /boot and prevents modifying the contents of that directory. This turns up as a problem when we try to modify the dtoverlay. On Raspberry Pi images from Bookworm, partition 1 is mounted as /boot/firmware. On the Orange Pi images we use, partition 1 is a data folder for cloud-init and should be mounted at /CIDATA. This PR overrides the automatic mounting of partition 1 and instead leaves it to the appropriate install script to mount any partitions other than root as appropriate for that image.
The Luma P1 camera was not loading correctly after flashing a new image. This was traced to an incorrect value for "cameraVideoModeIndex" in the sqlite database included with the image. This PR updates the database so that it has a valid video mode. Fixes PhotonVision#121
thatcomputerguy0101
force-pushed
the
trixie
branch
from
e4c78c8 to
85f3d3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing Debian Trixie