-
Notifications
You must be signed in to change notification settings - Fork 0
Initial schema #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ohler55
wants to merge
2
commits into
master
Choose a base branch
from
graphql-schema
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
|
|
||
| type Query { | ||
| frameworks: [Framework!] | ||
| framework(id: ID!): Framework | ||
|
|
||
| languages: [Language!] | ||
| language(id: ID!): Language | ||
|
|
||
| concurrencys: [Concurrency!] | ||
| concurrency(id: ID!): Concurrency | ||
|
|
||
| keys: [Key!] | ||
| key(id: ID!): Key | ||
|
|
||
| metrics: [Metric!] | ||
| metric(id: ID!): Metric | ||
|
|
||
| values: [Value!] | ||
| value(id: ID!): Value | ||
| } | ||
|
|
||
| type Framework { | ||
| id: ID | ||
| label: String! | ||
| language: Language | ||
| } | ||
|
|
||
| type Langauge { | ||
| id: ID | ||
| label: String! | ||
| } | ||
|
|
||
| type Concurrency { | ||
| id: ID | ||
| level: Int | ||
| } | ||
|
|
||
| type Key { | ||
| id: ID | ||
| label: String! | ||
| } | ||
|
|
||
| type Metric { | ||
| id: ID | ||
| framework: Framework | ||
| value: Value | ||
| concurrency: Concurrency | ||
| } | ||
|
|
||
| type Value { | ||
| id: ID | ||
| value: Int | ||
| key: Key | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ohler55 Those are values stored in database stored as
floatbenchmarker-data/db/migrations/0005_values.rb
Line 6 in dd0549b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have thought so too. The seed script seemed to use setting an attribute called value with an int. Maybe that is meant to be something else. I did not see a float being set in the seeding though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you know what attributes are in the Postgres tables I'll update based on that. That would be better than inspecting a seeded object after it is created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely. In fact, there are stored as
double precisionin postgresql (honestly in prefer not to take care of other engines) and considered asFloatinRubyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No matter if seeds uses
Integer😛 they are automatically casted before storing indatabaseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change pushed.