Skip to content

Simplify Workerman code#8287

Merged
waghanza merged 3 commits intothe-benchmarker:masterfrom
joanhey:patch-1
Mar 23, 2025
Merged

Simplify Workerman code#8287
waghanza merged 3 commits intothe-benchmarker:masterfrom
joanhey:patch-1

Conversation

@joanhey
Copy link
Contributor

@joanhey joanhey commented Mar 10, 2025

And with better performance

ping @walkor

And with better performance
@joanhey joanhey requested a review from waghanza as a code owner March 10, 2025 18:10
Copy link
Collaborator

@waghanza waghanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is is not a matter of (only) performance ...

I mean the idea is to compare fraeworks (perf, overhead, latency, readability ...).

Maybe best to introduce routing feature

cc @walkor

@joanhey
Copy link
Contributor Author

joanhey commented Mar 22, 2025

I only simplify the code for better readability.
And with the change match() is faster than switch().

I can't add a router, as Workerman don't have any official router, any dev can use any router.

Some frameworks in this bench use Workerman with different routers:

  • Mark: Workerman with fastroute
  • Nano
  • Webman
  • Comet
  • MixPHP
  • Imi
  • ...

Copy link
Collaborator

@waghanza waghanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, for now ...

I mean the endpoints will change so this code will need to be change, but we will do this later ...

PS : Please do not merge, I'll do it

@waghanza waghanza merged commit b2afa11 into the-benchmarker:master Mar 23, 2025
2 checks passed
@joanhey joanhey deleted the patch-1 branch March 23, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants