-
Notifications
You must be signed in to change notification settings - Fork 8
Refactor and clarify setup_selfbuild.md and setup_debian.md #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Organize repository clone & tag checkout as numbered steps - Replace unstructured bash blocks with clear Markdown headings
- Add “Prerequisites & System User” section with draupnir user creation - Organize repository clone & tag checkout as numbered steps - Consolidate clone, tag checkout, dependency install & build under draupnir user
b803531 to
96d6650
Compare
|
Looks ok now, the link to the Node.js install instructions I did provide because downloading and executing shell scripts from the internet might be a bit scary to some people, so that was added as a way to check where this is coming from. The other change to git checkout on the release tag instead of latest is up to Gnuxie to decide. |
ll-SKY-ll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Draupnir requires Node.js 20.x. Install via NodeSource: | ||
|
|
||
| ```bash | ||
| curl -fsSL https://deb.nodesource.com/setup_20.x -o nodesource_setup.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably ok, what alternative do we have?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't really like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Their website is absolutely crazy and screams untrustworthyness https://nodesource.com/. This may be normal for corporate foss but at the same time i will need to do some investigating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok looking at various github profiles this is legit it's just however owns the company is the one who must not be trusted.
| ```bash | ||
| latest_tag=$(git tag --sort=version:refname | tail -n1) | ||
| git checkout "$latest_tag" | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea 👍
Gnuxie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @ll-SKY-ll do these comments answer your questions? Sorry for the late response.
This PR makes the following high-level changes:
setup_selfbuild.md
setup_debian.md
draupnirsystem userSigned-off-by: Tealk tealk@rollenspiel.monster