Skip to content

Conversation

@Tealk
Copy link

@Tealk Tealk commented Sep 26, 2025

This PR makes the following high-level changes:

  • setup_selfbuild.md

    • Added explicit checkout of the latest release tag
    • Reorganized into numbered sections (clone & tags, install & build, configure, run)
  • setup_debian.md

    • Added explicit checkout of the latest release tag
    • Introduced a prerequisites section and non-login draupnir system user
    • Split into a clear 10-step process (packages, Node.js 20, Yarn, dirs, clone & build, config, systemd, update)

Signed-off-by: Tealk tealk@rollenspiel.monster

- Organize repository clone & tag checkout as numbered steps
- Replace unstructured bash blocks with clear Markdown headings
- Add “Prerequisites & System User” section with draupnir user creation
- Organize repository clone & tag checkout as numbered steps
- Consolidate clone, tag checkout, dependency install & build under draupnir user
@Tealk Tealk force-pushed the feature/version_pinning branch from b803531 to 96d6650 Compare September 28, 2025 20:04
@Tealk Tealk requested a review from ll-SKY-ll October 4, 2025 09:09
@ll-SKY-ll
Copy link
Contributor

Looks ok now, the link to the Node.js install instructions I did provide because downloading and executing shell scripts from the internet might be a bit scary to some people, so that was added as a way to check where this is coming from.

The other change to git checkout on the release tag instead of latest is up to Gnuxie to decide.

Copy link
Contributor

@ll-SKY-ll ll-SKY-ll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks alright now

@Gnuxie / @FSG-Cat you would have to decide if you want to leave out the link to the node.js docs and also if you want to checkout on latest release tag instead of latest commit

Draupnir requires Node.js 20.x. Install via NodeSource:

```bash
curl -fsSL https://deb.nodesource.com/setup_20.x -o nodesource_setup.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably ok, what alternative do we have?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't really like this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Their website is absolutely crazy and screams untrustworthyness https://nodesource.com/. This may be normal for corporate foss but at the same time i will need to do some investigating.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok looking at various github profiles this is legit it's just however owns the company is the one who must not be trusted.

Comment on lines +245 to +248
```bash
latest_tag=$(git tag --sort=version:refname | tail -n1)
git checkout "$latest_tag"
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea 👍

Copy link
Member

@Gnuxie Gnuxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @ll-SKY-ll do these comments answer your questions? Sorry for the late response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants