[fix]: fixes balanced subsampling bug in data/emnist.py#84
Open
mariovas3 wants to merge 1 commit intothe-full-stack:mainfrom
Open
[fix]: fixes balanced subsampling bug in data/emnist.py#84mariovas3 wants to merge 1 commit intothe-full-stack:mainfrom
mariovas3 wants to merge 1 commit intothe-full-stack:mainfrom
Conversation
…alling np.bincount in emnist balance subsampling np.bincount will prepend zeros for elements that were not found starting from 0 to y_min_element-1; this will bias the mean to be lower if not controlled and will result in fewer samples in the balanced dataset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Account for
ylabels being offset byNUM_SPECIAL_TOKENSwhen callingnp.bincountin emnist balance subsampling.The offsetting is found here:
fsdl-text-recognizer-2022/text_recognizer/data/emnist.py
Line 104 in ac59bfe
and here:
fsdl-text-recognizer-2022/text_recognizer/data/emnist.py
Line 106 in ac59bfe
np.bincountwill prepend zeros for elements that were not found starting from0toy_min_element-1; this will bias the mean to be lower if not controlled and will result in fewer samples in the balanced dataset.Example bug: