Skip to content

Add Angular 20 to package.json #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PowerKiKi merged 7 commits into from
May 30, 2025
Merged

Add Angular 20 to package.json #2360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
adc4fe5
Add Angular 20 to package.json
mark7-bell May 29, 2025
3f9ab3d
Add Angular 20 to the testing matrix in main.yml.
mark7-bell May 29, 2025
7e6d08e
Update main.yml
mark7-bell May 29, 2025
975c12c
Drop support for Angular 17
PowerKiKi May 30, 2025
f7dda4e
Test on node 22 and 24
PowerKiKi May 30, 2025
9c2c9c8
Support component without suffix in e2e
PowerKiKi May 30, 2025
36ee0c2
Declare Angular 20 support
PowerKiKi May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lazy-plants-poke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'apollo-angular': major
---

Drop support for Angular 17
Copy link

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changeset also declares a major bump. Consolidate with the other changeset so both Angular 20 support and Angular 17 drop are released together.

Suggested change
Drop support for Angular 17
Drop support for Angular 17 and add support for Angular 20

Copilot uses AI. Check for mistakes.
5 changes: 5 additions & 0 deletions .changeset/yellow-points-sort.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'apollo-angular': major
Copy link

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two separate major changeset files for apollo-angular. Merge these into a single changeset to prevent multiple major bumps in one release.

Copilot uses AI. Check for mistakes.
---

Support Angular 20
19 changes: 17 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,24 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
angular_version: [17, 18, 19]
angular_version: [18, 19, 20]
graphql_version: [15, 16]
node_version: [18, 20]
node_version: [18, 20, 22, 24]
exclude:
- angular_version: 18
node_version: 22

- angular_version: 18
node_version: 24

- angular_version: 19
node_version: 22

- angular_version: 19
node_version: 24

- angular_version: 20
node_version: 18
steps:
- name: Use Node.js ${{ matrix.node_version }}
uses: actions/setup-node@master
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"test:schematics": "tsc -p schematics/tsconfig.test.json && node scripts/move-schematics.js && jasmine --config=schematics/jasmine.json"
},
"peerDependencies": {
"@angular/core": "^17.0.0 || ^18.0.0 || ^19.0.0",
"@angular/core": "^18.0.0 || ^19.0.0 || ^20.0.0",
"@apollo/client": "^3.13.1",
"graphql": "^15.0.0 || ^16.0.0",
"rxjs": "^6.0.0 || ^7.0.0"
Expand Down
7 changes: 6 additions & 1 deletion scripts/prepare-e2e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ const cwd = process.cwd();
const [, , name, version] = process.argv;

function updateComponent() {
let filepath = path.join(cwd, `./${name}/src/app/app.component.ts`);
let filepath =
[
path.join(cwd, `./${name}/src/app/app.component.ts`),
path.join(cwd, `./${name}/src/app/app.ts`),
].find(path => fs.existsSync(path));
Copy link

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The callback parameter path shadows the imported path module. Consider renaming the parameter (e.g., p or candidatePath) to avoid confusion.

Suggested change
].find(path => fs.existsSync(path));
].find(candidatePath => fs.existsSync(candidatePath));

Copilot uses AI. Check for mistakes.

const code =
`import { Apollo } from 'apollo-angular';\n` +
`import { versionInfo } from 'graphql';\n` +
Expand Down