Apollo Client v4 compatibility #2372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it is EOL
To avoid error during cloudflare/wrangler-action as explained in cloudflare/wrangler-action#181
* Drop support for GraphQL 15 Fixes the-guild-org#2324 * chore(dependencies): updated changesets for modified dependencies --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jerelmiller
force-pushed
the
jerel/apollo-client-v4
branch
from
6fb3d0a to
2f5146c
Compare
jerelmiller
commented
Sep 19, 2025
jerelmiller
commented
Sep 19, 2025
jerelmiller
commented
Sep 19, 2025
jerelmiller
commented
Sep 19, 2025
jerelmiller
commented
Sep 19, 2025
Collaborator
I used to have a warning or error (don't remember) about react/rehackt when I was doing ... something... maybe building the demo app... But I don't see this anymore, so thank for reverting my change. I also reverted it in our docs.
Don't worry about that. I'll take care of it when merging. |
Collaborator
|
@jerelmiller, thank you a lot for all your work here, and all your hard work at apollo-client too. I really have no idea when I would have found so much time to do it myself. Thanks ! 👍 |
Contributor
Author
|
@PowerKiKi you're very welcome! Glad I could help! Appreciate the kind words ❤️ |
This was referenced Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got a large chunk of the code updated to use the new types and remove some features that no longer exist in Apollo Client 4.0 (many of them
ObservableQuerymethods).This isn't 100% complete so I'm leaving this in draft now. If possible, I could use a little bit of help figuring out why some of the tests/types fail. At the very least, this should provide significant progress!
I will continue a bit more work on this, but wanted to get some initial work out there and start a discussion. Thanks!
Checklist:
was reached (not necessary for small changes)