New onlyComplete() helper to filter only complete results#2379
Merged
New onlyComplete() helper to filter only complete results#2379
onlyComplete() helper to filter only complete results#2379Conversation
If you use this, you should probably combine it with [`notifyOnNetworkStatusChange`](https://www.apollographql.com/docs/react/data/queries#queryhookoptions-interface-notifyonnetworkstatuschange). This tells `@apollo/client` to not emit the first `partial` result, so `apollo-angular` does not need to filter it out. The overall behavior is identical, but it saves some CPU cycles. So something like this: ```ts apollo .watchQuery({ query: myQuery, notifyOnNetworkStatusChange: false, // Adding this will save CPU cycles }) .valueChanges .pipe(onlyComplete()) .subscribe(result => { // Do something with complete result }); ```
Contributor
💻 Website PreviewThe latest changes are available as preview in: https://pr-2379.apollo-angular.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you use this, you should probably combine it with
notifyOnNetworkStatusChange. This tells@apollo/clientto not emit the firstpartialresult, soapollo-angulardoes not need to filter it out. The overall behavior is identical, but it saves some CPU cycles.So something like this: