Skip to content

pflog: the default rulenr is "-1" #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

pflog: the default rulenr is "-1" #1089

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb6ddad
pflog: the default rulenr is "-1"
fichtner Oct 9, 2023
0403ad2
pflog: use the OpenBSD way of printing this edge case
fichtner Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions print-pflog.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,12 @@ pflog_print(netdissect_options *ndo, const struct pfloghdr *hdr)
ndo->ndo_protocol = "pflog";
rulenr = GET_BE_U_4(hdr->rulenr);
subrulenr = GET_BE_U_4(hdr->subrulenr);
if (subrulenr == (uint32_t)-1)
ND_PRINT("rule %u/", rulenr);
else {
if (subrulenr == (uint32_t)-1) {
if (rulenr == (uint32_t)-1)
ND_PRINT("rule %d/", -1);
else
ND_PRINT("rule %u/", rulenr);
} else {
ND_PRINT("rule %u.", rulenr);
nd_printjnp(ndo, (const u_char*)hdr->ruleset, PFLOG_RULESET_NAME_SIZE);
ND_PRINT(".%u/", subrulenr);
Expand Down