Conversation
thetypefounders
approved these changes
Apr 6, 2025
tests/index.test.ts
Outdated
Comment on lines
31
to
32
| async function request(path: string): Promise<express.Response> { | ||
| while (true) { |
There was a problem hiding this comment.
The infinite loop in the 'request' helper could cause tests to hang indefinitely if the server does not respond. Consider adding a maximum retry count or a timeout mechanism.
Suggested change
| async function request(path: string): Promise<express.Response> { | |
| while (true) { | |
| async function request(path: string, maxRetries: number = 5): Promise<express.Response> { | |
| let retries = 0; | |
| while (retries < maxRetries) { |
tests/index.test.ts
Outdated
| expect(response.status).toBe(500); | ||
| }); | ||
|
|
||
| async function request(path: string): Promise<express.Response> { |
There was a problem hiding this comment.
The function 'request' is declared to return an 'express.Response', but it actually returns the result of a fetch call (a standard Response). Update the return type to match the actual response type, such as 'Promise'.
Suggested change
| async function request(path: string): Promise<express.Response> { | |
| async function request(path: string): Promise<Response> { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.