Open
Conversation
Based on: https://caniusevia.com/docs/built_in_menus#qmk_rgb_matrix * Update effect name labels * Update "Effect Speed" element condition * Hide "Color" element for effects for which do not use it
Collaborator
|
@DEREFERENC3D mark ready when needed |
Author
|
@Cipulot Sorry, I got a little busy and kind of forgot about this PR. I've gone through the guide and done a quick re-test after upgrading to the latest mainline QMK, it should be ready. I am only unsure about the alpha, modifier and accent key colors, but I guess that will come out in review - for now I'm keeping the OEM-provided values, which match the single-color stock keycaps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the RK61. Based on the OEM-provided config file, cleaned up and updated to match the keyboard's definition in mainline QMK.
QMK Pull Request
qmk/qmk_firmware#25694
VIA Keymap Pull Request
the-via/qmk_userspace_via#118
Checklist
0xFEED