feat(registry-cli): add download, create-alias, upgrade commands#176
feat(registry-cli): add download, create-alias, upgrade commands#176
Conversation
his allows users to fetch the bytes of a publish Wasm and to upgrade deployed contracts.
chadoh
left a comment
chadoh
left a comment
There was a problem hiding this comment.
Let's make a better helpdoc, but otherwise this looks good!
| Publish(Box<publish::Cmd>), | ||
| /// Deploy a named contract from a published Wasm | ||
| Deploy(Box<deploy::Cmd>), | ||
| /// Fetch a published Wasm |
There was a problem hiding this comment.
| /// Fetch a published Wasm | |
| /// Fetch a published Wasm's bytes, defaulting to the most recent version |
There was a problem hiding this comment.
To download a copy of the contract?
chadoh
left a comment
chadoh
left a comment
There was a problem hiding this comment.
Let's rename some things before we merge!
fetchtodownloadinstalltocreate-alias
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
|
FYI build needs attention @willemneal |
willemneal
changed the title
|
@pselle I think it's all sorted. THe issues around the resource limits I think have to do with trying to upload the same wasm multiple times. To get around this I added some random bytes to the end of each one so that they are unique. I needed to add an extra dependncy which is why the cache was invalidated. So 🤞 |
|
@willemneal Ah, that's a good thing to remember! |
pselle
force-pushed
the
feat/registry_fetch_and_such
branch
from
32203ba to
e19da8a
Compare
…' into feat/registry_fetch_and_such
tupui
left a comment
tupui
left a comment
There was a problem hiding this comment.
Nice, some non blocking suggestions otherwise I had tested this locally and was working good 👍
There was a problem hiding this comment.
In case you don't know about this action, I like to use stellar/actions/rust-cache. I sort of delegate using this and sure that I am compatible.
| edition = "2021" | ||
| rust-version = "1.70" |
There was a problem hiding this comment.
I suppose we should also do this here as well?
| edition = "2024" | |
| rust-version = "1.89" |
There was a problem hiding this comment.
Hmm, yes we should have. I'm running through https://doc.rust-lang.org/edition-guide/editions/transitioning-an-existing-project-to-a-new-edition.html to see how that does with a full upgrade flow with the current main branch
| edition = "2021" | ||
| rust-version = "1.70" |
There was a problem hiding this comment.
| edition = "2021" | |
| rust-version = "1.70" | |
| edition = "2024" | |
| rust-version = "1.89" |
There was a problem hiding this comment.
Just to mention it. I actually have a .config/soroban because it used to be .soroban before the rename 😅 But I guess we can just assume that people using Scaffold would be new and not have that issue.
| .join(".config") | ||
| .join("stellar") |
There was a problem hiding this comment.
Elsewhere you do a single join. Not sure that matters.
There was a problem hiding this comment.
Should we also call create-alias at the end? Users most likely will want to do that after no?
There was a problem hiding this comment.
In prepping for the demo video we talked about maybe making this a default behavior! I like it as a "what's next" idea
chadoh
left a comment
chadoh
left a comment
There was a problem hiding this comment.
Wowowowowow this is a lot to take in but GREAT JOB 👏🏼 👏🏼 👏🏼
| ## [0.0.13](https://github.com/theahaco/scaffold-stellar/compare/stellar-scaffold-cli-v0.0.12...stellar-scaffold-cli-v0.0.13) - 2025-10-03 | ||
|
|
||
| ### Fixed | ||
|
|
||
| - default to development environment ([#206](https://github.com/theahaco/scaffold-stellar/pull/206)) | ||
|
|
There was a problem hiding this comment.
This would be my fault 😅 I did not know we were doing that so I did not have it in my PR.
4 participants
This allows users to fetch the bytes of a publish Wasm and to upgrade deployed contracts.