feat!: Use semver::Version instead of custom type#71
Merged
willemneal merged 3 commits intomainfrom May 23, 2025
Merged
Conversation
BlaineHeffron
approved these changes
May 22, 2025
Contributor
BlaineHeffron
left a comment
BlaineHeffron
left a comment
There was a problem hiding this comment.
Looks good but there is a failing check.
While semver is no_std, it still requires an allocator. Furthermore wasm32v1-none doesn't support std. And the initial implementation of alloc in the soroban_sdk required the use of `extern crate std`. This was fixed in the newest version of the soroban-sdk but we need to update the loam-sdk to handle this change. So for now can ship the same allocator implementation soroban-sdk provides. Once updated we can remove it.
willemneal
force-pushed
the
feat/use_proper_version_type
branch
from
4b1dfca to
10c331b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Cargo.toml stores versions as strings and users will expect to be able to use them directly when passing a version, this PR uses strings as inputs and stores the versions as strings. It also uses the
semvercrate to validate that the input version strings and to ensure that a publish can only publish a version that is greater than the most recent one!This also has the added benefit of handling any version type cargo supports such as prereleases!