[Error handling] Remove category from exceptions #211
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @cvergne thank you for this contribution! Can you update the code to fix the pipeline? |
|
Hello @homersimpsons That's why I left the PR in draft as it's not ready. |
|
The upstream pull request has been merged. This one should most likely be merged (but needs an upgrade of graphqlite library) |
@homersimpsons this is not so easy #203 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply changes from thecodingmachine/graphqlite#685 to the bundle.
Warning
Do no not merge until merge and release of thecodingmachine/graphqlite#685
Note
Still having error running test about
DependencyInjection/Configuration.phpnot compatible with implemented interface. Not fixed it in this PR (as already done in #208), but should probably split it into a distinct PR.