Skip to content

Fixed incorrect assertions #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fixed incorrect assertions #723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/Mappers/Parameters/TypeHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public function mapReturnType(
$refMethod,
$docBlockObj,
);
assert(! $type instanceof InputType);
assert($type instanceof OutputType);
} catch (CannotMapTypeExceptionInterface $e) {
$e->addReturnInfo($refMethod);
throw $e;
Expand Down Expand Up @@ -160,7 +160,12 @@ private function getDocBlockPropertyType(DocBlock $docBlock, ReflectionProperty
return reset($varTags)->getType();
}

public function mapParameter(ReflectionParameter $parameter, DocBlock $docBlock, Type|null $paramTagType, ParameterAnnotations $parameterAnnotations): ParameterInterface
public function mapParameter(
ReflectionParameter $parameter,
DocBlock $docBlock,
Type|null $paramTagType,
ParameterAnnotations $parameterAnnotations,
): ParameterInterface
{
$hideParameter = $parameterAnnotations->getAnnotationByType(HideParameter::class);
if ($hideParameter) {
Expand Down Expand Up @@ -327,7 +332,7 @@ public function mapInputProperty(
$inputType = $this->typeResolver->mapNameToInputType($inputTypeName);
} else {
$inputType = $this->mapPropertyType($refProperty, $docBlock, true, $argumentName, $isNullable);
assert(! $inputType instanceof OutputType);
assert($inputType instanceof InputType);
}

$hasDefault = $defaultValue !== null || $isNullable;
Expand Down
Loading