Skip to content

Update doctrine/coding-standard requirement from ^12.0 to ^12.0 || ^13.0 #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 26, 2025
Merged

Update doctrine/coding-standard requirement from ^12.0 to ^12.0 || ^13.0 #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a22c981
Update doctrine/coding-standard requirement from ^12.0 to ^12.0 || ^13.0
dependabot[bot] Mar 24, 2025
134a6e9
Run PHPCS on the target PHP version
oojacoboo Mar 26, 2025
3b05516
Specify phpcs vendor/bin path
oojacoboo Mar 26, 2025
758b36e
Only run CS checks on the minimum supported version
oojacoboo Mar 26, 2025
d0fb42f
Resolve duplicate code coverage artifact name collision
oojacoboo Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/continuous_integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,21 +74,22 @@ jobs:
- name: "Run static code analysis with phpstan/phpstan"
run: "composer phpstan"

- name: "Run coding standard checks with squizlabs/php_codesniffer"
run: "composer cs-check"
- name: "Run coding standard checks with squizlabs/php_codesniffer on minimum supported PHP version"
if: matrix.php-version == '8.1'
run: composer cs-check

- name: "Archive code coverage results"
uses: actions/upload-artifact@v4
with:
name: codeCoverage-${{ matrix.php-version }}
name: codeCoverage-${{ matrix.php-version }}-${{ github.run_id }}
path: "build"
overwrite: true

- uses: codecov/[email protected] # upload the coverage to codecov
with:
fail_ci_if_error: false # optional (default = false) - Need CODECOV_TOKEN
# Do not upload in forks, and only on php8.3, latest deps
if: ${{ github.repository == 'thecodingmachine/graphqlite' && matrix.php-version == '8.3' && matrix.install-args == '' }}
# Do not upload in forks, and only on php8.4, latest deps
if: ${{ github.repository == 'thecodingmachine/graphqlite' && matrix.php-version == '8.4' && matrix.install-args == '' }}

examples:
name: Check Examples
Expand All @@ -103,7 +104,7 @@ jobs:
- name: "Install PHP with extensions"
uses: "shivammathur/setup-php@v2"
with:
php-version: "8.2"
php-version: "8.4"
tools: composer:v2
- name: "Install dependencies with composer"
working-directory: "examples/${{ matrix.example }}"
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
},
"require-dev": {
"beberlei/porpaginas": "^2.0",
"doctrine/coding-standard": "^12.0",
"doctrine/coding-standard": "^12.0 || ^13.0",
"ecodev/graphql-upload": "^7.0",
"laminas/laminas-diactoros": "^3.5",
"myclabs/php-enum": "^1.6.6",
Expand Down
Loading