docs: fix broken anchors and stale Doctrine annotation references#799
Merged
oojacoboo merged 1 commit intothecodingmachine:masterfrom Apr 22, 2026
Conversation
Doctrine annotation support was dropped in thecodingmachine#677, and the relevant section headings were subsequently renamed from "annotation"/"annotations" to "attribute"/"attributes". A handful of in-repo links and wording were missed in that rename: - annotations-reference.md #[Type] section: `#input-annotation` / `#factory-annotation` → `#input` / `#factory` (sections are now `## #[Input]` and `## #[Factory]`). - authentication-authorization.mdx + fine-grained-security.mdx: `#logged-and-right-annotations` → `#logged-and-right-attributes` (section is `## #[Logged]` and `#[Right]` attributes`). - queries.mdx "About attributes": the Doctrine example was shown as `#[Query]`, which is the new-style syntax. Corrected to `@Query` and rephrased the line so the old-vs-new distinction actually reads. - annotations-reference.md intro: reworded to reflect that only the PHP 8 attribute format exists now; kept the link to the migration guide since existing users still need it. - annotations-reference.md #[Assertion]: Type column said `annotation` while the description said `attributes` — aligned to `attribute`. Intentionally left alone: CHANGELOG.md (historical), migrating.md (historical migration guide), doctrine-annotations-attributes.mdx (migration guide, still useful), and the `annotations` parameter on #[SourceField] / #[MagicField] (actual PHP parameter name in the source). PHP namespace references (TheCodingMachine\GraphQLite\ Annotations\*) are real symbol names and not stale.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #799 +/- ##
============================================
- Coverage 95.72% 94.84% -0.89%
- Complexity 1773 1869 +96
============================================
Files 154 175 +21
Lines 4586 5079 +493
============================================
+ Hits 4390 4817 +427
- Misses 196 262 +66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Doctrine annotation support was dropped in #677, and the relevant section headings were subsequently renamed from "annotation(s)" to "attribute(s)". A handful of in-repo links and wording were missed in that rename — this PR cleans them up.
Broken anchors (navigation currently breaks)
annotations-reference.md#[Type]section:#input-annotation/#factory-annotation→#input/#factory(sections are now## #[Input]and## #[Factory]).authentication-authorization.mdx+fine-grained-security.mdx:#logged-and-right-annotations→#logged-and-right-attributes(section is###[Logged]and#[Right]attributes).Stale / contradictory wording
queries.mdx"About attributes": the Doctrine example was shown as#[Query], which is the new-style syntax. Corrected to@Queryand rephrased so the old-vs-new distinction actually reads.annotations-reference.mdintro: reworded to reflect that only the PHP 8 attribute format exists now. Kept the link to the migration guide since existing users still benefit from it.annotations-reference.md#[Assertion]: Type column saidannotationwhile the description saidattributes— aligned toattribute.Intentionally left alone
CHANGELOG.md— historical record.migrating.md— historical migration guide, references@SourceFieldetc. on purpose.doctrine-annotations-attributes.mdx— migration guide, still useful for users on the old syntax.annotationsparameter on#[SourceField]/#[MagicField]— that's the actual PHP parameter name in the source, not stale terminology.TheCodingMachine\GraphQLite\Annotations\*— real symbol names.Test plan