Add parameter to shwo message if no more result in evolugrid#44
Open
gregoireMIAGE wants to merge 3 commits intothecodingmachine:6.0from
Open
Add parameter to shwo message if no more result in evolugrid#44gregoireMIAGE wants to merge 3 commits intothecodingmachine:6.0from
gregoireMIAGE wants to merge 3 commits intothecodingmachine:6.0from
Conversation
nguyenk
reviewed
Oct 30, 2018
Member
nguyenk
left a comment
nguyenk
left a comment
There was a problem hiding this comment.
Maybe you should remove the styling from the JS part (init, line 750).
You already have a class for that element. So maybe but the base CSS into evolugrid.css and leave it up to the developers to override default styling?
Member
|
@nguyenk : that would be a very good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.