Require safe ^1.2 #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.0 and 1.1 use `resource` as a literal type hint, which is interpreted as a class name, which results in error reports (I'm not sure why anybody would be using safe v1.0 or v1.1, but our test suite checks with `--prefer-lowest`, and I'm not sure why that didn't catch this issue earlier)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
=========================================
Coverage 57.74% 57.74%
Complexity 53 53
=========================================
Files 9 9
Lines 142 142
=========================================
Hits 82 82
Misses 60 60 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.0 and 1.1 use
resourceas a literal type hint, which is interpreted as a class name, which results in error reports(I'm not sure why anybody would be using safe v1.0 or v1.1, but our test suite checks with
--prefer-lowest, and I'm not sure why that didn't catch this issue earlier)