Improving test coverage

Author: moufmouf

tests/TDBMAbstractServiceTest.php

@@ -421,8 +421,10 @@ private static function initSchema(Connection $connection): void
             $connection->exec('CREATE TABLE `players` (
                `id` INT UNSIGNED AUTO_INCREMENT NOT NULL,
                `player_and_games` JSON NOT NULL,
-               `names_virtual` VARCHAR(20) GENERATED ALWAYS AS (`player_and_games` ->> \'$.name\') NOT NULL COMMENT \'@Generated\', 
-               PRIMARY KEY (`id`)
+               `names_virtual` VARCHAR(20) GENERATED ALWAYS AS (`player_and_games` ->> \'$.name\') NOT NULL COMMENT \'@Generated\',
+               `animal_id` INT COMMENT \'@Generated\',
+               PRIMARY KEY (`id`),
+               FOREIGN KEY (animal_id) REFERENCES animal(id)
             );
             ');
         }

tests/TDBMDaoGeneratorTest.php

@@ -92,6 +92,7 @@
 use TheCodingMachine\TDBM\Utils\PathFinder\PathFinder;
 use TheCodingMachine\TDBM\Utils\TDBMDaoGenerator;
 use Symfony\Component\Process\Process;
+use function get_class;
 
 class TDBMDaoGeneratorTest extends TDBMAbstractServiceTest
 {
@@ -2282,7 +2283,7 @@ public function testFindFromRawSQLOnInheritance(): void
 
     public function testGeneratedColumnsAreNotPartOfTheConstructor(): void
     {
-        if ($this->tdbmService->getConnection()->getDatabasePlatform() instanceof MySqlPlatform && !self::isMariaDb($this->tdbmService->getConnection())) {
+        if (!$this->tdbmService->getConnection()->getDatabasePlatform() instanceof MySqlPlatform || self::isMariaDb($this->tdbmService->getConnection())) {
             $this->markTestSkipped('ReadOnly column is only tested with MySQL');
         }
 
@@ -2318,7 +2319,7 @@ public function testGeneratedColumnsAreNotPartOfTheConstructor(): void
 
     public function testCanReadVirtualColumn(): void
     {
-        if ($this->tdbmService->getConnection()->getDatabasePlatform() instanceof MySqlPlatform && !self::isMariaDb($this->tdbmService->getConnection())) {
+        if (!$this->tdbmService->getConnection()->getDatabasePlatform() instanceof MySqlPlatform || self::isMariaDb($this->tdbmService->getConnection())) {
             $this->markTestSkipped('ReadOnly column is only tested with MySQL');
         }