Merged
Conversation
Jay-Lalwani
force-pushed
the
enhanced-search
branch
from
874ea78 to
f7cd46c
Compare
Collaborator
Author
|
Discuss whether or not to include the courses that the selected filtered instructors are teaching in the current semester or have taught in any semester. |
Collaborator
Author
|
To setup db for enhanced-search: Reset DB: Load latest course info: |
Collaborator
Author
|
Key Files: Front-end search filtering page (as of right now): tcf_website/templates/browse/browse.html & tcf_website/views/browse.py Search functionality: tcf_website/views/search.py |
merging dev to this branch
1. Removed indicator for filters active and instead button displays "Filters Active". Added Javascript to detect if filters are active. 2. Shortened subject and discipline lists 3. Added searchbar for disciplines list 4. Fixed search icon not showing up in subjects/discipline search bar 5. Improved color consistency
version. Retained most of the original logic but added fix to allow for query and filters. Fixed icon issue cause by loading in Font-Awesome Icons incorrectly causing icons to break.
…orum/theCourseForum2 into enhanced_search_brian
Enhanced search david -> enhanced search
Enhanced-search-brian merge to enhanced-search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did