Skip to content

Deprecate lfs, use gdown for downloading latest.sql#989

Merged
barrettruth merged 13 commits intodevfrom
deprecate-lfs
Jan 30, 2025
Merged

Deprecate lfs, use gdown for downloading latest.sql#989
barrettruth merged 13 commits intodevfrom
deprecate-lfs

Conversation

@angadv12
Copy link
Contributor

@angadv12 angadv12 commented Jan 29, 2025

GitHub Issues addressed

  • This PR closes

What I did

  • Deprecated git-lfs for tracking latest.sql file.
  • Added gdown to setup.sh script to check for gdown install and auto download latest.sql from tCF Google Drive using file ID in sharing link.
  • Updated dev.md to include gdown as prereq prior to running one command curl setup.

Screenshots

  • Before
image - After image

Testing

  • Ran test fresh setup using curl -fL 'https://raw.githubusercontent.com/thecourseforum/theCourseForum2/refs/heads/master/scripts/setup.sh' | sh -s -- <install_dir>. Correctly pulled latest.sql from Google Drive and placed into db/latest.sql.

Questions/Discussions/Notes

  • Future: can research method of scanning google drive db files to download most recent one (can normalize method of naming files using dates and use that to scan files)

@angadv12 angadv12 requested a review from barrettruth January 29, 2025 22:01
requirements.txt Outdated
django-heroku~=0.3.1
django-stubs~=4.2.7
djangorestframework~=3.14.0
gdown~=5.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GDown is only necessary for the setup script, not for the docker continaer. I think this should be removed - what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right I didn't even think of that, I'll remove.

@angadv12 angadv12 requested a review from barrettruth January 30, 2025 02:37
@barrettruth barrettruth merged commit 9f310ea into dev Jan 30, 2025
3 checks passed
@barrettruth barrettruth deleted the deprecate-lfs branch January 30, 2025 03:05
chaizhang pushed a commit that referenced this pull request Aug 10, 2025
Deprecate lfs, use gdown for downloading latest.sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants