Fixed #243 (adding pams crops compatibility)#244
Open
TimeyDingo wants to merge 6 commits intothedarkcolour:1.20.1from
Open
Fixed #243 (adding pams crops compatibility)#244TimeyDingo wants to merge 6 commits intothedarkcolour:1.20.1from
TimeyDingo wants to merge 6 commits intothedarkcolour:1.20.1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
-Adds new compatibility folder and file which registers pams harvestcraft crops automatically by searching the registry namespace for crops that match the pams naming convention
-registers that in the correct farm type
What it doesn't
-I could not figure out how to add pams to the runClient task for actual testing, so I manually tested it in my minecraft installation after building, would recommend adding that in the future though if someone else more knowledgeable on that can do it
-haven't added compatibility with pams trees just crops
compat with
https://www.curseforge.com/minecraft/mc-mods/pams-harvestcraft-2-crops
https://www.curseforge.com/minecraft/mc-mods/pams-harvestcraft-2-food-core