Pass changed attrs to "validated:*" events #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeron-diovis
force-pushed
the
pass_changed_attrs_to_validation_events
branch
from
0000000 to
1bee0f3
Compare
|
Not seeing any unit tests here. |
|
@jeron-diovis Actually: Just wondering, have you tried using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't attach validation mixin through view and mixing it directly to model,
we don't have access to valid/invalid callbacks. So we can use only "validated:*" events.
And so - we never know which exactly attributes was validated, which is very important information.
Need to pass list of changed attributes to validation events.