replace Event::fire() with Event::dispatch() for L5.8#241
Open
MostafaAttia wants to merge 1 commit intothedevdojo:masterfrom
Open
replace Event::fire() with Event::dispatch() for L5.8#241MostafaAttia wants to merge 1 commit intothedevdojo:masterfrom
MostafaAttia wants to merge 1 commit intothedevdojo:masterfrom
Conversation
|
This fix worked for me on L5.8 - please merge it. |
|
please merge it. |
|
i am not sure what happened but in every branch this has reverted to fire() ?? |
|
Can this be merged? |
|
Please merge this - i just raised an issue relating to this. |
|
Yes, This worked for me. Thanks! |
GareginDavtyan
approved these changes
Nov 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't create a new discussion when using Laravel 5.8:
Symfony\Component\Debug\Exception\FatalThrowableError Call to undefined method Illuminate\Events\Dispatcher::fire().Illuminate\Events\Dispatcher::fire()changed todispatchin Laravel 5.8