Closed
Conversation
Contributor
|
Thank you for the addition of the TH05F, Could you also add the following to the PR, to get it ready for merging? • Add 2-3 test cases in the appropriate sections of https://github.com/theengs/decoder/blob/development/tests/BLE/test_ble.cpp • with the above also requiring an entry for the TH05F in https://github.com/theengs/decoder/blob/development/src/decoder.h • add a documentation page for the TH05F, which also mentions that the TH05F decoder only works with BTHome v2 firmware without encryption, similar to https://github.com/theengs/decoder/blob/development/docs/devices/MJWSD05MMC.md |
Author
|
I'll review the PR as soon as possible and cover those points. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds support for the Tuya TH05F (internal TH05Y - https://pvvx.github.io/TH05F/) device running pvvx v2.1 firmware
Checklist: