-
Notifications
You must be signed in to change notification settings - Fork 106
Add KernelCare Clients for Debian/Ubuntu #4000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add KernelCare Clients for Debian/Ubuntu #4000
Conversation
|
The PR preview for 778cc63 is available at theforeman-foreman-documentation-preview-pr-4000.surge.sh The following output files are affected by this PR: |
Lennonka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this should also get a single procedure and a reference?
98d23e1 to
0845d15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Recommended to address Brian's suggestion.
0845d15 to
60fbbc7
Compare
maximiliankolb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Brian & Lena.
|
Can you add Debian13 and EL10 OSses? Then, we should add this nice addition. |
There are no KernelCare Clients for Debian 13 or EL 10: I can add them in a follow-up PR as soon as they're published. @sbernhard |
I had a look again and found https://docs.tuxcare.com/live-patching-services/ in which new repo urls are specified - including debian 13. Actually, I would vote to to remove the table, describe the common procedure how to use the repos and point to this documentation to get always the latest repo state. Then, we don't need to maintain the list of repos. |
This patch drops the procedure to add KernelCare clients for EL and instead moves all necessary information for EL and Deb to tables. Refs 29eda6f
60fbbc7 to
9e5e1e0
Compare
maximiliankolb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the table and replaced it with a link to the KernelCare documentation. Ready for re-review.
|
@sbernhard I have applied your suggestion. Please re-review. |
What changes are you introducing?
Add KernelCare Clients for Debian/Ubuntu
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
I was only checking for EL10 which are not yet released, but then realized that they're missing for Debian & Ubuntu. I did not find any Clients for SLES.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into:
Review checklists
Tech review (performed by an Engineer who did not author the PR; can be skipped if tech review is unnecessary):
Style review (by a Technical Writer who did not author the PR):