-
Notifications
You must be signed in to change notification settings - Fork 106
Reword template based provisioning #4295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maximiliankolb
wants to merge
2
commits into
theforeman:master
Choose a base branch
from
ATIX-AG:fix_4288_reword_template_based_provisioning
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
guides/common/modules/proc_adding-vmware-images-to-project-by-using-cli.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| :_mod-docs-content-type: PROCEDURE | ||
|
|
||
| [id="adding-vmware-images-to-{project-context}-by-using-cli"] | ||
| = Adding VMware images to {Project} by using CLI | ||
|
|
||
| Add VMware images to {Project} to perform image-based host provisioning on VMware. | ||
|
|
||
| .Procedure | ||
| . Optional: View all available images on VMware: | ||
| + | ||
| [options="nowrap" subs="+quotes"] | ||
| ---- | ||
| $ hammer compute-resource image available --compute-resource "_My_VMware" | ||
| ---- | ||
| . Add your Proxmox image to {Project}: | ||
| + | ||
| [options="nowrap" subs="+quotes"] | ||
| ---- | ||
| $ hammer compute-resource image create \ | ||
| --architecture "_My_Architecture_" \ | ||
| --compute-resource "_My_VMware_" \ | ||
| --name "_My_Image_Name_" \ | ||
| --operatingsystem "_My_Operating_System_" \ | ||
| --username _My_User_Name_ \ | ||
| --uuid "_My_UUID_" | ||
| ---- | ||
|
|
||
| .Verification | ||
| * Verify that the VMware image is present on your {Project}: | ||
| + | ||
| [options="nowrap" subs="+quotes"] | ||
| ---- | ||
| $ hammer compute-resource image list --compute-resource "_My_VMware_" | ||
| ---- |
20 changes: 20 additions & 0 deletions
20
guides/common/modules/proc_adding-vmware-images-to-project-by-using-web-ui.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| :_mod-docs-content-type: PROCEDURE | ||
|
|
||
| [id="adding-vmware-images-to-{project-context}-by-using-web-ui"] | ||
| = Adding VMware images to {Project} by using {ProjectWebUI} | ||
|
|
||
| Add VMware images to {Project} to perform image-based host provisioning on VMware. | ||
|
|
||
| .Procedure | ||
| . In the {ProjectWebUI}, navigate to *Infrastructure* > *Compute Resources*. | ||
| . Select your VMware compute resource. | ||
| . Click *Create Image*. | ||
| . In the *Name* field, enter a name for the image. | ||
| . From the *Operating System* list, select the base operating system of the image. | ||
| . From the *Architecture* list, select the operating system architecture. | ||
| . In the *Username* field, enter the SSH user name for image access. | ||
| By default, this is set to `root`. | ||
| . If your image supports user data input such as `cloud-init` data, click the *User data* checkbox. | ||
| . Optional: In the *Password* field, enter the SSH password to access the image. | ||
| . From the *Image* list, select an image from VMware. | ||
| . Click *Submit* to save the image details. |
40 changes: 0 additions & 40 deletions
40
guides/common/modules/proc_adding-vmware-images-to-server.adoc
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I struggled to remember why this wording was so strange (in VMware).
The problem is this: what we call "images" in Foreman are called "templates" in VMware. I don't know what they call them in Proxmox. I started calling them "image templates" in provisioning methods.
Now I hesitate to change it because it would be good for users' understanding to create a connection between those two terminologies. Could you try to consider an alternative wording?
This applies to all modules in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can drop 9c3aaf4 from the PR and only add the CLI procecures for now. Or is this something I should bring up in the provisioning interest group? cc @goarsna
Or maybe we need to extend our glossary/provisioning overview?