Skip to content

Conversation

@Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Oct 22, 2025

What changes are you introducing?

Adding short descriptions to Hammer cheat sheet reference modules where previously missing

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

DITA compliance

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

  • These abstracts were more-or-less AI generated.
  • This is the last PR for Hammer CLI guide, hopefully!

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Oct 22, 2025
@Lennonka Lennonka force-pushed the comply-dita-using-hammer-missing-abstracts branch from 20887fa to 63f061f Compare October 22, 2025 00:13
@github-actions
Copy link

github-actions bot commented Oct 22, 2025

@Lennonka Lennonka removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Oct 22, 2025
@Lennonka Lennonka marked this pull request as draft October 22, 2025 00:23
@Lennonka Lennonka marked this pull request as ready for review October 22, 2025 00:37
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I am not the biggest fan of "Learn ...".


[role="_abstract"]
Learn the Hammer CLI commands for creating activation keys and adding subscriptions in {ProjectName}.
You use these commands to manage activation keys that automatically configure systems during registration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You use these commands to manage activation keys that automatically configure systems during registration.
You use these commands to manage activation keys that automatically configure hosts during registration.

IMO "configure hosts" is a bit of a stretch. Configuring what? subscription-manager uses AK (and CV envs) to setup content that hosts can consume.

Refs https://docs.theforeman.org/nightly/Managing_Hosts/index-katello.html#registering-a-host_managing-hosts

== Content life cycles

[role="_abstract"]
Learn the Hammer CLI commands for managing lifecycle environments and content views in {ProjectName}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Learn the Hammer CLI commands for managing lifecycle environments and content views in {ProjectName}.
Learn the Hammer CLI commands for managing content views in lifecycle environments in {ProjectName}.


[role="_abstract"]
Learn the Hammer CLI commands for managing lifecycle environments and content views in {ProjectName}.
You use these commands to control content promotion and version management across environments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You use these commands to control content promotion and version management across environments.
You use these commands to promote content across lifecycle environments.


[role="_abstract"]
Learn the Hammer CLI commands for managing security updates and patches in {ProjectName}.
You use these commands to list, inspect, and apply errata to keep your systems secure and up-to-date.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You use these commands to list, inspect, and apply errata to keep your systems secure and up-to-date.
You use these commands to list, inspect, and apply errata to keep your hosts secure and up-to-date.

Comment on lines +7 to +8
Learn essential information for using Hammer CLI in {ProjectName} effectively.
You need to understand authentication, help options, and organization requirements before executing commands.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Learn essential information for using Hammer CLI in {ProjectName} effectively.
You need to understand authentication, help options, and organization requirements before executing commands.
There are certain options for using Hammer CLI in {ProjectName} that apply to all commands, including authentication and getting help.

Comment on lines +7 to +8
Learn the Hammer CLI commands for managing hosts, host groups, and remote job execution in {ProjectName}.
You use these commands to create and configure systems, organize them into groups, and execute tasks remotely.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Learn the Hammer CLI commands for managing hosts, host groups, and remote job execution in {ProjectName}.
You use these commands to create and configure systems, organize them into groups, and execute tasks remotely.
Learn the Hammer CLI commands for managing hosts, host groups, and remote job execution in {ProjectName}.
You use these commands to configure host group and to create hosts.

IMO organizing them into groups would be host collections. host group are more like blueprints.


[role="_abstract"]
Learn the Hammer CLI commands for managing organizations, locations, and repositories.
You use these commands to structure your environment and manage content synchronization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You use these commands to structure your environment and manage content synchronization.


[role="_abstract"]
Learn the Hammer CLI commands for creating provisioning infrastructure components in {ProjectName}.
You use these commands to set up domains, subnets, compute resources, and templates for automated system deployment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You use these commands to set up domains, subnets, compute resources, and templates for automated system deployment.
You use these commands to set up domains, subnets, compute resources, and templates for automated host provisioning.

IMO it's nice if we stick closer to the name of the guide & avoid using different terminology.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of scope: https://docs.theforeman.org/nightly/Hammer_CLI/index-katello.html#tasks looks off. IMO there should be a second row starting with "Monitor progress...".

Copy link
Member

@aneta-petrova aneta-petrova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I am not the biggest fan of "Learn ...".

I second that sentiment. IMO we should consider phrasing like "Learn [...]" or similar as self-referential text: It's not providing much value because of course users read docs to learn things ;) (EDIT: Or, to be clearer, they already know they're learning.) @Lennonka since this was AI-generated or AI-assisted, could you please look into tweaking your prompt?

@pr-processor pr-processor bot added the Waiting on contributor Requires an action from the author label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs style review Requires a review from docs style/grammar perspective Waiting on contributor Requires an action from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants