-
Notifications
You must be signed in to change notification settings - Fork 106
Comply with DITA - Using Hammer - missing abstracts #4401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Comply with DITA - Using Hammer - missing abstracts #4401
Conversation
20887fa to
63f061f
Compare
|
The PR preview for f353323 is available at theforeman-foreman-documentation-preview-pr-4401.surge.sh The following output files are affected by this PR: |
maximiliankolb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I am not the biggest fan of "Learn ...".
|
|
||
| [role="_abstract"] | ||
| Learn the Hammer CLI commands for creating activation keys and adding subscriptions in {ProjectName}. | ||
| You use these commands to manage activation keys that automatically configure systems during registration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| You use these commands to manage activation keys that automatically configure systems during registration. | |
| You use these commands to manage activation keys that automatically configure hosts during registration. |
IMO "configure hosts" is a bit of a stretch. Configuring what? subscription-manager uses AK (and CV envs) to setup content that hosts can consume.
| == Content life cycles | ||
|
|
||
| [role="_abstract"] | ||
| Learn the Hammer CLI commands for managing lifecycle environments and content views in {ProjectName}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Learn the Hammer CLI commands for managing lifecycle environments and content views in {ProjectName}. | |
| Learn the Hammer CLI commands for managing content views in lifecycle environments in {ProjectName}. |
|
|
||
| [role="_abstract"] | ||
| Learn the Hammer CLI commands for managing lifecycle environments and content views in {ProjectName}. | ||
| You use these commands to control content promotion and version management across environments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| You use these commands to control content promotion and version management across environments. | |
| You use these commands to promote content across lifecycle environments. |
|
|
||
| [role="_abstract"] | ||
| Learn the Hammer CLI commands for managing security updates and patches in {ProjectName}. | ||
| You use these commands to list, inspect, and apply errata to keep your systems secure and up-to-date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| You use these commands to list, inspect, and apply errata to keep your systems secure and up-to-date. | |
| You use these commands to list, inspect, and apply errata to keep your hosts secure and up-to-date. |
| Learn essential information for using Hammer CLI in {ProjectName} effectively. | ||
| You need to understand authentication, help options, and organization requirements before executing commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Learn essential information for using Hammer CLI in {ProjectName} effectively. | |
| You need to understand authentication, help options, and organization requirements before executing commands. | |
| There are certain options for using Hammer CLI in {ProjectName} that apply to all commands, including authentication and getting help. |
| Learn the Hammer CLI commands for managing hosts, host groups, and remote job execution in {ProjectName}. | ||
| You use these commands to create and configure systems, organize them into groups, and execute tasks remotely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Learn the Hammer CLI commands for managing hosts, host groups, and remote job execution in {ProjectName}. | |
| You use these commands to create and configure systems, organize them into groups, and execute tasks remotely. | |
| Learn the Hammer CLI commands for managing hosts, host groups, and remote job execution in {ProjectName}. | |
| You use these commands to configure host group and to create hosts. |
IMO organizing them into groups would be host collections. host group are more like blueprints.
|
|
||
| [role="_abstract"] | ||
| Learn the Hammer CLI commands for managing organizations, locations, and repositories. | ||
| You use these commands to structure your environment and manage content synchronization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| You use these commands to structure your environment and manage content synchronization. |
|
|
||
| [role="_abstract"] | ||
| Learn the Hammer CLI commands for creating provisioning infrastructure components in {ProjectName}. | ||
| You use these commands to set up domains, subnets, compute resources, and templates for automated system deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| You use these commands to set up domains, subnets, compute resources, and templates for automated system deployment. | |
| You use these commands to set up domains, subnets, compute resources, and templates for automated host provisioning. |
IMO it's nice if we stick closer to the name of the guide & avoid using different terminology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of scope: https://docs.theforeman.org/nightly/Hammer_CLI/index-katello.html#tasks looks off. IMO there should be a second row starting with "Monitor progress...".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I am not the biggest fan of "Learn ...".
I second that sentiment. IMO we should consider phrasing like "Learn [...]" or similar as self-referential text: It's not providing much value because of course users read docs to learn things ;) (EDIT: Or, to be clearer, they already know they're learning.) @Lennonka since this was AI-generated or AI-assisted, could you please look into tweaking your prompt?
What changes are you introducing?
Adding short descriptions to Hammer cheat sheet reference modules where previously missing
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
DITA compliance
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: