-
Notifications
You must be signed in to change notification settings - Fork 106
Add details for upgrading external postgres from 12 to 13 #4441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.12
Are you sure you want to change the base?
Add details for upgrading external postgres from 12 to 13 #4441
Conversation
|
The PR preview for f491012 is available at theforeman-foreman-documentation-preview-pr-4441.surge.sh The following output files are affected by this PR: |
Lennonka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweaks :)
guides/common/modules/proc_upgrading-postgresql-on-the-external-database-system.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_upgrading-postgresql-on-the-external-database-system.adoc
Show resolved
Hide resolved
Lennonka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SME review would be appreciated.
guides/common/modules/proc_upgrading-postgresql-on-the-external-database-system.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_upgrading-postgresql-on-the-external-database-system.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_upgrading-postgresql-on-the-external-database-system.adoc
Show resolved
Hide resolved
guides/common/modules/proc_upgrading-postgresql-on-the-external-database-system.adoc
Show resolved
Hide resolved
Lennonka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM style wise
|
@AkshayGadhaveRH Since upgrade is a critical task, I would strongly prefer to have the new procedure tested by a QE. |
stejskalleos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the official RHEL 8 documentation, I see that the steps introduced here are duplicated; everything needed for the upgrade is already described in that documentation.
The procedure should be:
. Back up the `/var/lib/pgsql/data/postgresql.conf` and `/var/lib/pgsql/data/pg_hba.conf` files. (BTW, this step is mentioned in the el8 docs)
. Follow RHEL8 docs
. Make sure it's running.
guides/common/modules/proc_upgrading-postgresql-on-the-external-database-system.adoc
Show resolved
Hide resolved
Existing documentation points to the RHEL docs for steps to upgrade external DB. However, some steps need to be tweaked. JIRA: https://issues.redhat.com/browse/SAT-37171
7902608 to
f491012
Compare
stejskalleos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tech ACK
Existing documentation points to the RHEL docs for steps to upgrade external DB. However, some steps need to be tweaked.
JIRA:
https://issues.redhat.com/browse/SAT-37171
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: