Skip to content

Conversation

@aneta-petrova
Copy link
Member

@aneta-petrova aneta-petrova commented Jan 26, 2026

What changes are you introducing?

  • Adding a line with the new RHOKP URL setting to the admin settings reference table
  • Moving the section on RHOKP to Admin (or Planning)
  • Extending the section on RHOKP with information about the new setting

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

RedHatSatellite/foreman_theme_satellite#305 adds the setting.

The changes listed in the "What" part are based on the requirements defined in https://issues.redhat.com/browse/SAT-41491.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

N/A

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Jan 26, 2026
@aneta-petrova aneta-petrova removed Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Jan 26, 2026
@aneta-petrova aneta-petrova force-pushed the SAT-41491_rhokp-setting branch 4 times, most recently from 6f2cfb2 to 1b3f779 Compare January 26, 2026 12:15
@aneta-petrova
Copy link
Member Author

Hi @ofedoren, this is where I'm developing documentation for the new RHOKP setting. It's still a draft but already shows the expected nature and extent of the docs update. (No need to review just yet, unless you really want to, because we still need to wait for the couple of open questions in the code PR to be resolved.)

@aneta-petrova
Copy link
Member Author

Hi @Lennonka, would you have time for a quick look at a Planning guide update of mine in return? ;) I'm looking for a place for the RHOKP section somewhere else than in disconnected docs; the solution from ticket reporter was Admin (where the new setting is expected to be documented) but I was thinking Planning might give the RHOKP concept description more visibility.

I'm not looking for a complete review yet (because parts of the text might still change quite a bit based on how the code evolves) but if you have time for a quick review of the placement I propose, that would be awesome.

@aneta-petrova aneta-petrova added the Waiting for code Requires merge of related code in another repository before it can be merged label Jan 26, 2026
@aneta-petrova aneta-petrova force-pushed the SAT-41491_rhokp-setting branch from 1b3f779 to e748bb0 Compare January 27, 2026 17:06
@aneta-petrova aneta-petrova force-pushed the SAT-41491_rhokp-setting branch from e748bb0 to f942d3e Compare January 27, 2026 17:06
@aneta-petrova aneta-petrova marked this pull request as ready for review January 27, 2026 17:13
@aneta-petrova aneta-petrova added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing and removed Waiting for code Requires merge of related code in another repository before it can be merged labels Jan 27, 2026
@aneta-petrova
Copy link
Member Author

@ofedoren I think this is ready for review now. Can you please take a look?

@aneta-petrova aneta-petrova removed the Needs style review Requires a review from docs style/grammar perspective label Jan 27, 2026
@aneta-petrova aneta-petrova added style review done No issues from docs style/grammar perspective Waiting for code Requires merge of related code in another repository before it can be merged labels Jan 27, 2026
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aneta-petrova, seems complete and correct to me!

@aneta-petrova aneta-petrova added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Jan 28, 2026
@aneta-petrova aneta-petrova force-pushed the SAT-41491_rhokp-setting branch from cc4bb2c to 147b5f0 Compare January 28, 2026 13:17
@aneta-petrova aneta-petrova removed the Waiting for code Requires merge of related code in another repository before it can be merged label Jan 29, 2026
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, I missed this earlier. Would be worth checking.

Co-authored-by: Lena Ansorgová <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs testing Requires functional testing style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants