-
Notifications
You must be signed in to change notification settings - Fork 108
Document RHOKP URL setting #4611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Document RHOKP URL setting #4611
Conversation
6f2cfb2 to
1b3f779
Compare
|
Hi @ofedoren, this is where I'm developing documentation for the new RHOKP setting. It's still a draft but already shows the expected nature and extent of the docs update. (No need to review just yet, unless you really want to, because we still need to wait for the couple of open questions in the code PR to be resolved.) |
|
Hi @Lennonka, would you have time for a quick look at a Planning guide update of mine in return? ;) I'm looking for a place for the RHOKP section somewhere else than in disconnected docs; the solution from ticket reporter was Admin (where the new setting is expected to be documented) but I was thinking Planning might give the RHOKP concept description more visibility. I'm not looking for a complete review yet (because parts of the text might still change quite a bit based on how the code evolves) but if you have time for a quick review of the placement I propose, that would be awesome. |
1b3f779 to
e748bb0
Compare
e748bb0 to
f942d3e
Compare
|
@ofedoren I think this is ready for review now. Can you please take a look? |
ofedoren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @aneta-petrova, seems complete and correct to me!
Co-authored-by: Maximilian Kolb <[email protected]>
cc4bb2c to
147b5f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies, I missed this earlier. Would be worth checking.
guides/common/modules/con_red-hat-offline-knowledge-portal.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Lena Ansorgová <[email protected]>
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
RedHatSatellite/foreman_theme_satellite#305 adds the setting.
The changes listed in the "What" part are based on the requirements defined in https://issues.redhat.com/browse/SAT-41491.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
N/A
Contributor checklists
Please cherry-pick my commits into: