Add additional permissions for KubeVirt #4618
Open
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Needs tech review
|
The PR preview for e3abe81 is available at theforeman-foreman-documentation-preview-pr-4618.surge.sh The following output files are affected by this PR: |
guides/common/modules/con_provisioning-virtual-machines-on-kubevirt.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_provisioning-virtual-machines-on-kubevirt.adoc
Outdated
Show resolved
Hide resolved
maximiliankolb
changed the title
guides/common/modules/con_provisioning-virtual-machines-on-kubevirt.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Maximilian Kolb <[email protected]>
pr-processor
bot
added
Needs re-review
and removed
Waiting on contributor
Co-authored-by: Aneta Šteflová Petrová <[email protected]>
evgeni
reviewed
Jan 28, 2026
guides/common/modules/con_provisioning-virtual-machines-on-kubevirt.adoc
Outdated
Show resolved
Hide resolved
evgeni
reviewed
Jan 29, 2026
guides/common/modules/con_provisioning-virtual-machines-on-kubevirt.adoc
Show resolved
Hide resolved
Co-authored-by: Evgeni Golov <[email protected]>
evgeni
approved these changes
Jan 29, 2026
maximiliankolb
added
tech review done
Lennonka
approved these changes
Jan 29, 2026
Contributor
Lennonka
left a comment
Lennonka
left a comment
There was a problem hiding this comment.
A couple of cosmetic suggestions. Otherwise LGTM
guides/common/modules/con_provisioning-virtual-machines-on-kubevirt.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_provisioning-virtual-machines-on-kubevirt.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Lena Ansorgová <[email protected]>
Lennonka
added
style review done
Contributor
|
If it doesn't need testing, please remove the label. Then I can merge. |
maximiliankolb
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Add more specific necessary and optional permissions.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
https://issues.redhat.com/browse/SAT-41542
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: