Require base64 for Ruby 3.4 #1025
Conversation
|
Argh, now puppet-puppetserver_foreman requires a newer version. You just can't win with this. https://github.com/theforeman/puppet-puppetserver_foreman/pull/52/files#r2075602218 and I'll check if we can lower that bound. |
Oh yes... I should have called this out more specifically as this was the one I saw in the logs that led me to open the PR. |
| gem 'rake' | ||
|
|
||
| if RUBY_VERSION >= '3.4' | ||
| gem 'base64' |
|
|
||
| if RUBY_VERSION >= '3.4' | ||
| gem 'base64' | ||
| gem 'getoptlong' |
There was a problem hiding this comment.
Did you figure out why we need this? We should make sure that dependency pulls it in.
There was a problem hiding this comment.
There was a problem hiding this comment.
That already lists and we list puppet so why do we need to list it again?
There was a problem hiding this comment.
Sorry, I linked to the wrong version, 7.34.0 is used in SRPM build and you will note this is missing there:
https://github.com/puppetlabs/puppet/blob/7.34.0/puppet.gemspec
There was a problem hiding this comment.
Should we move to using Puppet 8 instead of trying to fix it with Puppet 7? I'm a bit worried about other dragons hiding in there.
There was a problem hiding this comment.
That thought crossed my mind. I thought maybe we should get builds back on track with 7 and then investigate puppet 8 / openvox.
2 participants
I am testing if these fix things or not. I noticed Packit switched to Fedora 42 w/ Ruby 3.4 which is where the base64 requirement came from in the Gemfile.