Skip to content

Test charts before PF5#483

Merged
MariaAga merged 3 commits intotheforeman:masterfrom
ofedoren:test-charts
Mar 17, 2025
Merged

Test charts before PF5#483
MariaAga merged 3 commits intotheforeman:masterfrom
ofedoren:test-charts

Conversation

@ofedoren
Copy link
Member

No description provided.

@ofedoren
Copy link
Member Author

I'll fix the linter issue as soon as this gets reviewed.

Next week I won't be able to update this, so please feel free to either edit this PR with additional commits or take over in any way.

@MariaAga
Copy link
Member

I'm out tomorrow, this seem to work well, i did the whole npm link as well, and it shows pf5 charts (in rex) as expected with no error in page or in webpack compile.
can you update the the lint error for the tests and I'll get it in once its green(ish)?

@MariaAga MariaAga merged commit 4c297be into theforeman:master Mar 17, 2025
11 of 13 checks passed
@github-actions
Copy link

🎉 This PR is included in version 15.0.1 🎉

The release is available on:

Thank you for your contribution, your foreman-js bot 🤖

2 similar comments
@github-actions
Copy link

🎉 This PR is included in version 15.0.1 🎉

The release is available on:

Thank you for your contribution, your foreman-js bot 🤖

@github-actions
Copy link

🎉 This PR is included in version 15.0.1 🎉

The release is available on:

Thank you for your contribution, your foreman-js bot 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants