Fixes #38991 - Add chained task dependencies in the UI#788
Fixes #38991 - Add chained task dependencies in the UI#788adamruzicka merged 5 commits intotheforeman:masterfrom
Conversation
|
Katello PR to test with: Katello/katello#11540 |
| { | ||
| id: task.id, | ||
| action: task.action, | ||
| humanized: task.humanized[:action], | ||
| state: task.state, | ||
| result: task.result | ||
| } |
There was a problem hiding this comment.
I can't say I'm a huge fan of ad-hoc data formatting. Could we instead have a main rabl json template with this and have the other templates we already have extend it?
There was a problem hiding this comment.
@adamruzicka I moved the data modeling part to a rabl json file and included it in the rabl json here as a partial.
There was a problem hiding this comment.
That way the data is modeled once instead of twice. It's not exactly 'extending' as you mentioned, but lemme know if it does the trick for ya.
adamruzicka
left a comment
There was a problem hiding this comment.
Please bump dependency on dynflow, otherwise lgtm
|
@adamruzicka I've addressed the latest comments. |
|
Rubocop is failing because the version of Ruby is too old. |
|
Would you please include 8fb29ee here? |
fb8b258 to
4e47763
Compare
|
@adamruzicka 8fb29ee is included now. |
|
Instead of having this sort of read-only, I would still like to have an interface to actually chain tasks using the foreman-tasks without having users reach into dynflow's internals to manipulate things directly. Something like the previous iteration had |
8d01695 to
d7fe308
Compare
|
@adamruzicka I've created the public API for it. Now there is a solid dependency between this PR and Katello/katello#11621, so this will need to merge first. |
|
@adamruzicka I updated |
|
Thanks for the reviews! Glad to see this getting in, it's been a long time coming. |




Adds dependency information to the Foreman Tasks UI in a new Dependencies tab. Each dependency list is a table that shows the name of the task and the status.
Relates to Dynflow/dynflow#446