Skip to content

Fixes #38830 - Add submenu Host collections to bulk hosts Change associations#10721

Merged
MariaAga merged 1 commit intotheforeman:developfrom
lfu:31027_host_collection
Nov 3, 2025
Merged

Fixes #38830 - Add submenu Host collections to bulk hosts Change associations#10721
MariaAga merged 1 commit intotheforeman:developfrom
lfu:31027_host_collection

Conversation

@lfu
Copy link
Copy Markdown
Contributor

@lfu lfu commented Oct 13, 2025

@lfu
Copy link
Copy Markdown
Contributor Author

lfu commented Oct 13, 2025

Screenshot at 2025-10-13 14-32-32

@lfu lfu force-pushed the 31027_host_collection branch from 9b5bbc2 to f079442 Compare October 21, 2025 16:08
@jeremylenz jeremylenz requested a review from MariaAga October 27, 2025 21:07
@MariaAga
Copy link
Copy Markdown
Member

I'm ok with keeping the hosts table custom, but this PR breaks the job details page it seems:

JobInvocationHostTable.js:387 Uncaught TypeError: Cannot read properties of undefined (reading 'RowSelectTd')
    at JobInvocationHostTable.js:387:18
    at Array.map (<anonymous>)

Sorry, I wanted to keep the generic components in the generic folder, but REX imports from the host index folder import { RowSelectTd } from 'foremanReact/components/HostsIndex/RowSelectTd';

@jeremylenz
Copy link
Copy Markdown
Contributor

REX imports from the host index folder

Based on the search here

https://github.com/search?q=org%3Atheforeman%20foremanReact%2Fcomponents%2FHostsIndex%2FRowSelectTd&type=code

it appears REX is the only one that imports like this. Rather than revert the change here, I'm happy to raise a PR in REX if that sounds good to you?

@MariaAga
Copy link
Copy Markdown
Member

@jeremylenz That would be great

@jeremylenz
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Member

@MariaAga MariaAga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all!

@MariaAga MariaAga merged commit 15f80b4 into theforeman:develop Nov 3, 2025
108 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants