Fixes #38830 - Add submenu Host collections to bulk hosts Change associations#10721
Merged
MariaAga merged 1 commit intotheforeman:developfrom Nov 3, 2025
Merged
Fixes #38830 - Add submenu Host collections to bulk hosts Change associations#10721MariaAga merged 1 commit intotheforeman:developfrom
MariaAga merged 1 commit intotheforeman:developfrom
Conversation
Contributor
Author
jeremylenz
reviewed
Oct 13, 2025
webpack/assets/javascripts/react_app/components/HostsIndex/index.js
Outdated
Show resolved
Hide resolved
b7d1654 to
8b91655
Compare
8b91655 to
9b5bbc2
Compare
MariaAga
reviewed
Oct 21, 2025
webpack/assets/javascripts/react_app/components/PF4/TableIndexPage/RowSelectTd.js
Show resolved
Hide resolved
9b5bbc2 to
f079442
Compare
MariaAga
reviewed
Oct 22, 2025
webpack/assets/javascripts/react_app/components/PF4/TableIndexPage/Table/Table.js
Outdated
Show resolved
Hide resolved
f079442 to
d7e3651
Compare
MariaAga
reviewed
Oct 23, 2025
Member
|
I'm ok with keeping the hosts table custom, but this PR breaks the job details page it seems: Sorry, I wanted to keep the generic components in the generic folder, but REX imports from the host index folder |
Contributor
Based on the search here it appears REX is the only one that imports like this. Rather than revert the change here, I'm happy to raise a PR in REX if that sounds good to you? |
Member
|
@jeremylenz That would be great |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related to Katello/katello#11528