Fixes #38877 - Add Agama installer templates (SLES16)#10747
Merged
nadjaheitmann merged 1 commit intotheforeman:developfrom Mar 11, 2026
Merged
Fixes #38877 - Add Agama installer templates (SLES16)#10747nadjaheitmann merged 1 commit intotheforeman:developfrom
nadjaheitmann merged 1 commit intotheforeman:developfrom
Conversation
Contributor
|
Added some snapshots 😉 |
sbernhard
force-pushed
the
fix_38877
branch
7 times, most recently
from
46cbc47 to
50ebfd8
Compare
sbernhard
force-pushed
the
fix_38877
branch
2 times, most recently
from
4d25e98 to
724cb70
Compare
sbernhard
force-pushed
the
fix_38877
branch
8 times, most recently
from
1595e0a to
e470883
Compare
app/views/unattended/provisioning_templates/finish/agama_default_finish.erb
Outdated
Show resolved
Hide resolved
app/views/unattended/provisioning_templates/finish/agama_default_finish.erb
Show resolved
Hide resolved
app/views/unattended/provisioning_templates/provision/agama_sles_default.erb
Show resolved
Hide resolved
sbernhard
force-pushed
the
fix_38877
branch
4 times, most recently
from
38b6353 to
7c7e3be
Compare
bastelfreak
reviewed
Feb 6, 2026
app/views/unattended/partition_tables_templates/agama_default.erb
Outdated
Show resolved
Hide resolved
sbernhard
added a commit
to ATIX-AG/foreman
that referenced
this pull request
Feb 9, 2026
from theforeman#10747 Refs: OR-6522
sbernhard
added a commit
to ATIX-AG/foreman
that referenced
this pull request
Feb 9, 2026
Fixup - original PR: from theforeman#10747 Refs: OR-6522
bastelfreak
approved these changes
Feb 9, 2026
Member
bastelfreak
left a comment
bastelfreak
left a comment
There was a problem hiding this comment.
I'm far away from an Agama expert, but the change looks fine to me.
Contributor
|
Anything else that needs doing to get this merged? There's an ACK and at least two different people have commented/commited. Would you merge this? @nadjaheitmann |
nadjaheitmann
approved these changes
Mar 11, 2026
Contributor
nadjaheitmann
left a comment
nadjaheitmann
left a comment
There was a problem hiding this comment.
Yes, let's get this in. Thanks for the ping!
Thanks @sbernhard and everyone else!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.