Fixes 38993: add OpenVox repository by d1nuc0m · Pull Request #10816 · theforeman/foreman

d1nuc0m · 2026-01-14T14:03:48Z

Add OpenVox repository when relevant parameters are in use.

bastelfreak

I haven't tested this, but the changes look correct to me

ekohl · 2026-01-26T13:06:48Z

app/views/unattended/provisioning_templates/host_init_config/host_init_config_default.erb

 <%= snippet 'puppet_setup' %>
 <% end -%>

+<% if !host_param_true?('skip-openvox-setup') && (host_puppet_server.present? || host_param_true?('force-openvox')) -%>


I think this will mean it runs both Puppet and OpenVox setup. In app/views/unattended/provisioning_templates/user_data/userdata_default.erb you solved it with a force-puppet parameter and IMHO this part should be aligned.

Thinking about it maybe it should be like this:

if Puppet is explicitly forced, install it

Otherwise, default to OpenVox (instead of Puppet) if a Puppet Server is present and OpenVox setup is not explicitly skipped; or if OpenVox setup is forced

Btw, which should be the proper way to add an exception in case both force-puppet and force-openvox are true?

And, is there a way to add tests to templates?

Thinking about it maybe it should be like this:

I think that's good

Btw, which should be the proper way to add an exception in case both force-puppet and force-openvox are true?

I'd also be OK with just assuming OpenVox then. In environments where Katello is used you control the availability via synced content anyway and it's irrelevant. You only need the configuration to be done.

And, is there a way to add tests to templates?

We render snapshots, so that can be used. It's a fairly heavy process though because it usually results in huge files to be included.

I'd also be OK with just assuming OpenVox then

Ok, it should work like this now

We render snapshots, so that can be used. It's a fairly heavy process though

There isn't something like Rspec to render templates with variables and check if they contain/do not contain what's expected?

Thanks, I tried to write a test based on your code and existing tests, where could I find some docs for FactoryBot.create? I'd like to add more OSes. Also, is the test part of the suite now or should I add it somewhere?

We use factory_bot which has its own documentation: https://thoughtbot.github.io/factory_bot/

Also, in #9516 there's some work to clean up the factories and make them more extensible..

Thanks, I am implementing Debian/Ubuntu tests and just discovered it doesn't work

@ekohl done, to add OSes like Ubuntu 24.04, it should be added to test/factories/operatingsystem.rb before? And, is it enough to place the voxpupuli repo test file in test/unit/foreman/templates/snippets or I should declare it somewhere?

ekohl

I think this is starting to look very good.

ekohl · 2026-01-30T10:28:46Z

app/views/unattended/provisioning_templates/user_data/userdata_default.erb

 - |
 <%= indent(2) { snippet('chef_client') } %>
 <% end -%>
+<% if openvox_enabled -%>


I'd like to prevent the case where both Vox and Puppet repos are enabled so perhaps this can be:

if openvox_enabled → snippet('voxpupuli_repo')

else if puppet_enabled → snippet('puppetlabs_repo')

if openvox_enabled or puppet_enabled →snippet('puppet_setup')

That probably needs some redefinition of puppet_enabled

Ok, I'll try after Fosdem/CfgMgmtCamp

I'm back, had some "offline" issues meanwhile

sbernhard · 2026-02-19T13:17:50Z

app/views/unattended/provisioning_templates/cloud_init/cloud_init_default.erb

 <% if host_param_true?('enable-puppetlabs-repo') || host_param_true?('enable-official-puppet8-repo') || host_param_true?('enable-official-puppet7-repo') || host_param_true?('enable-puppetlabs-puppet6-repo') || host_param_true?('enable-puppetlabs-puppet5-repo') -%>
 <%= indent(2) { snippet 'puppetlabs_repo' } %>
 <% end -%>
+<% if host_param_true?('enable-openvox8') || host_param_true?('enable-openvox7') -%>


actually, enabling the openvox repos is no necessary, if the packages are provided by katello. Can you please add a guard?
This can be done at this stage or later on in the voxpupuli_repo snippet.

sbernhard

The voxpupuli_repo repo setup is not required, if the openvox packages are delivered by katello.

d1nuc0m · 2026-02-25T15:39:19Z

@sbernhard any suggestion on how to implement it? I never used Katello and was copying the Puppet setup

sbernhard · 2026-03-02T11:06:56Z

@sbernhard any suggestion on how to implement it? I never used Katello and was copying the Puppet setup

One possibility would be to "just" check for:
if (plugin_present?('katello') in the template.

But this would mean, that for every katello we would expect that openvox is delivered through katello (which I would prefer if I would katello).

Another idea would be, to check for an additonal host param like "use-openvox-voxpupuli-repo" - this parameter can then be used, if maybe a user want to use the openvox packages delieverd by the OS vendor, too.

d1nuc0m · 2026-03-02T13:02:03Z

Another idea would be, to check for an additonal host param like "use-openvox-voxpupuli-repo" - this parameter can then be used, if maybe a user want to use the openvox packages delieverd by the OS vendor, too.

userdata_default.erb already has a skip-openvox-setup variable, maybe is extending that a solution?

d1nuc0m · 2026-03-05T14:51:47Z

@ekohl can I ask for help with the tests? I have added a file to test puppet_setup snippet, and locally it fails with

PuppetSetupTest::RHEL 9#test_0001_enable-openvox8:
NoMethodError: undefined method `find_snippet' for #<OpenStruct name="Test", content="<%#\nkind: snippet\nname: puppet_setup\nmodel: ProvisioningTemplate\nsnippet: true\ndescription: 
(...) 
app/services/foreman/renderer/scope/macros/snippet_rendering.rb:49:in `snippet'
app/services/foreman/renderer/safe_mode_renderer.rb:7:in `render'
app/services/foreman/renderer/base_renderer.rb:18:in `render'
test/unit/foreman/templates/snippets/puppet_setup.rb:25:in `render_template'
test/unit/foreman/templates/snippets/puppet_setup.rb:36:in `block (2 levels) in <class:PuppetSetupTest>'

(etc, same for other OSes)

I don't know how to handle it, and the GH pipeline reports tests are successful, so I guess these new two aren't being run?

* Add OpenVox repository when relevant parameters are in use * Test VoxPupuli repository and Puppet setup snippets when OpenVox parameters are set

pr-processor bot added Not yet reviewed Waiting on contributor labels Jan 14, 2026

github-actions bot added the Templates label Jan 14, 2026

d1nuc0m force-pushed the voxpupuli-repo branch from 5ec550b to 36ac7b9 Compare January 14, 2026 14:04

pr-processor bot removed the Waiting on contributor label Jan 14, 2026

bastelfreak approved these changes Jan 23, 2026

View reviewed changes

pr-processor bot removed the Not yet reviewed label Jan 23, 2026

ekohl reviewed Jan 26, 2026

View reviewed changes

d1nuc0m force-pushed the voxpupuli-repo branch 8 times, most recently from c80a5b2 to 62c80b9 Compare January 28, 2026 13:31

ekohl reviewed Jan 30, 2026

View reviewed changes

ekohl mentioned this pull request Jan 31, 2026

Swith to use openvox repo #10755

Draft

sbernhard reviewed Feb 19, 2026

View reviewed changes

sbernhard requested changes Feb 19, 2026

View reviewed changes

pr-processor bot added the Waiting on contributor label Feb 19, 2026

d1nuc0m force-pushed the voxpupuli-repo branch from 62c80b9 to c8d72e0 Compare March 5, 2026 14:16

pr-processor bot added Needs re-review and removed Waiting on contributor labels Mar 5, 2026

d1nuc0m force-pushed the voxpupuli-repo branch from c8d72e0 to 277a184 Compare March 5, 2026 14:19

d1nuc0m force-pushed the voxpupuli-repo branch from 277a184 to 58533b6 Compare March 6, 2026 09:15

d1nuc0m force-pushed the voxpupuli-repo branch 3 times, most recently from 0d96b86 to 2d18d15 Compare March 6, 2026 11:15

Fixes #38993: add OpenVox repository

c9b8e68

* Add OpenVox repository when relevant parameters are in use * Test VoxPupuli repository and Puppet setup snippets when OpenVox parameters are set

d1nuc0m force-pushed the voxpupuli-repo branch from 2d18d15 to c9b8e68 Compare March 6, 2026 11:17

sbernhard mentioned this pull request Mar 17, 2026

Fixes #36947 - Broken openSUSE Leap 15 provisioning #9927

Merged

Conversation

d1nuc0m commented Jan 14, 2026

Uh oh!

bastelfreak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

d1nuc0m Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

d1nuc0m Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

d1nuc0m Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ekohl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sbernhard left a comment

Choose a reason for hiding this comment

Uh oh!

d1nuc0m commented Feb 25, 2026

Uh oh!

sbernhard commented Mar 2, 2026

Uh oh!

d1nuc0m commented Mar 2, 2026

Uh oh!

d1nuc0m commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

d1nuc0m Jan 26, 2026 •

edited

Loading

d1nuc0m Jan 27, 2026 •

edited

Loading

d1nuc0m Jan 28, 2026 •

edited

Loading

d1nuc0m commented Mar 5, 2026 •

edited

Loading