-
Notifications
You must be signed in to change notification settings - Fork 1k
Fixes #38760 - Add loading skeleton to Change host group modal #10856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ba209a to
075ff85
Compare
jeremylenz
previously approved these changes
Feb 6, 2026
Contributor
jeremylenz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
Approved pending green tests & removal of that commit.
075ff85 to
8b92c60
Compare
Contributor
Author
Done :) |
Contributor
|
The test failure seems related 😖 |
The BulkReassignHostgroupModal now displays a skeleton loader while fetching hostgroup data, improving user experience by providing visual feedback during the loading state. The Save button is also disabled while data is loading to prevent premature submission.
8b92c60 to
b8fd2d0
Compare
jeremylenz
approved these changes
Feb 10, 2026
Contributor
|
This may need a followup. I'm now seeing this when I load All Hosts: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BulkReassignHostgroupModal now displays a skeleton loader while fetching hostgroup data, improving user experience by providing visual feedback during the loading state.
Steps to Reproduce:
Before the fix:
After the fix:
Screencast.From.2026-02-05.15-09-35.mp4