Fixes #39059 - Update PageLayout to use PF5 #10857
Open
+57
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukshio
reviewed
Feb 9, 2026
Contributor
Lukshio
left a comment
Lukshio
left a comment
There was a problem hiding this comment.
Hi, overall, it looks great. I didn't find any issues. I think we should set the searchBar width to 100% by default and use the toolbarItem widths to set the limitation.
webpack/assets/javascripts/react_app/components/SearchBar/SearchBar.scss
Show resolved
Hide resolved
webpack/assets/javascripts/react_app/routes/common/PageLayout/PageLayout.js
Outdated
Show resolved
Hide resolved
MariaAga
force-pushed
the
pagelayout-pf5
branch
from
c9a6926 to
984e6ea
Compare
Lukshio
reviewed
Feb 10, 2026
Contributor
Lukshio
left a comment
Lukshio
left a comment
There was a problem hiding this comment.
Css file can be replaced by adding alignSelf prop to ToolbarItem
webpack/assets/javascripts/react_app/routes/common/PageLayout/PageLayout.js
Outdated
Show resolved
Hide resolved
| )} | ||
| </ToolbarItem> | ||
| {isLoading && ( | ||
| <ToolbarItem id="toolbar-spinner"> |
Contributor
There was a problem hiding this comment.
Suggested change
| <ToolbarItem id="toolbar-spinner"> | |
| <ToolbarItem id="toolbar-spinner" alignSelf="center"> |
MariaAga
force-pushed
the
pagelayout-pf5
branch
from
984e6ea to
1e83211
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visually nothing should change, unless the toolbarButtons are PF3 and there are more than 1 of them, which from what I saw is only the tasks table.
tasks table buttons will get 0 space with this PR, but it will be fixed in a follow up PR in foreman-tasks
PageLayout is used in tasks table, audits list, Filters Form,
RegistrationCommands, UpgradePage and other plugins