Skip to content

Fixes #38470 - deprecate forms/Form.js #10861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lukshio wants to merge 1 commit into
base: develop
Choose a base branch
from
+29 −18
Open

Fixes #38470 - deprecate forms/Form.js #10861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 29 additions & 18 deletions webpack/assets/javascripts/react_app/components/common/forms/Form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import React from 'react';
import React, { useEffect } from 'react';
import PropTypes from 'prop-types';
import { Alert } from 'patternfly-react';

import { noop } from '../../../common/helpers';
import AlertBody from '../Alert/AlertBody';
import Actions from './Actions';
import { translate as __ } from '../../../../react_app/common/I18n';
import { deprecate } from '../../../common/DeprecationService';

const Form = ({
className,
Expand All @@ -17,23 +18,33 @@ const Form = ({
disabled,
submitting,
errorTitle,
}) => (
<form className={className} onSubmit={onSubmit}>
{error && (
<Alert className="base in fade" type={error.severity || 'danger'}>
<AlertBody title={errorTitle}>
{error.errorMsgs.length === 1 ? (
<span>{error.errorMsgs[0]}</span>
) : (
error.errorMsgs.map((e, idx) => <li key={idx}>{e}</li>)
)}
</AlertBody>
</Alert>
)}
{children}
<Actions onCancel={onCancel} disabled={disabled} submitting={submitting} />
</form>
);
}) => {
useEffect(() => {
deprecate('Form', 'Form from @patternfly/react-core', '3.20');
}, []);

return (
<form className={className} onSubmit={onSubmit}>
{error && (
<Alert className="base in fade" type={error.severity || 'danger'}>
<AlertBody title={errorTitle}>
{error.errorMsgs.length === 1 ? (
<span>{error.errorMsgs[0]}</span>
) : (
error.errorMsgs.map((e, idx) => <li key={idx}>{e}</li>)
)}
</AlertBody>
</Alert>
)}
{children}
<Actions
onCancel={onCancel}
disabled={disabled}
submitting={submitting}
/>
</form>
);
};

Form.propTypes = {
children: PropTypes.node,
Expand Down
Loading