Add mmx64.efi file to generated bootdisk #173
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Jun 2, 2025
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
For a production environment, the theforeman/foreman-packaging#12095 is required.
Actually, that is only for Satellite. It's unused in upstream. Upstream uses https://github.com/theforeman/puppet-foreman_proxy/blob/master/manifests/tftp/netboot.pp
Bootdisks generated by Foreman don't include the mmx64.efi file. Under certain circumstances, it may be necessary to boot the system for provisioning.
Collaborator
Author
|
thx, |
Collaborator
Author
|
ping @nofaralfasi |
nofaralfasi
approved these changes
Jun 26, 2025
Contributor
nofaralfasi
left a comment
nofaralfasi
left a comment
There was a problem hiding this comment.
The changes LGTM, but I haven’t tested them locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootdisks generated by Foreman don't include the mmx64.efi file.
Under certain circumstances, it may be necessary to boot the system for provisioning.
Upstream installer: theforeman/puppet-foreman_proxy#865
Downstream: theforeman/foreman-packaging#12095