Skip to content

Fixes #38664 - update to non deprecated dropdown #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stejskalleos merged 1 commit into from
Aug 26, 2025
+33 −11
Merged

Fixes #38664 - update to non deprecated dropdown #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 30 additions & 11 deletions webpack/src/extensions/host/HostBootdiskButtons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import React, { useEffect } from 'react';
import { useSelector, useDispatch } from 'react-redux';

import { DropdownItem, DropdownGroup } from '@patternfly/react-core/deprecated';
import {
DropdownItem,
DropdownGroup,
DropdownList,
Divider,
} from '@patternfly/react-core';
import {
BanIcon,
BuildIcon,
Expand All @@ -22,6 +27,7 @@ import {
selectIsLoading,
selectBootdiskOptions,
} from './HostBootdiskButtonsSelectors';
import './HostBootdiskButtons.scss';

const HostBootdiskButtons = () => {
const dispatch = useDispatch();
Expand Down Expand Up @@ -56,7 +62,7 @@ const HostBootdiskButtons = () => {
content = options.actions.map((action, i) => (
<DropdownItem
key={`bootdisk-${i}`}
href={foremanUrl(action.link)}
to={foremanUrl(action.link)}
isDisabled={action.disabled}
description={action.description}
icon={iconComponent(action.icon)}
Expand All @@ -71,12 +77,15 @@ const HostBootdiskButtons = () => {
key="bootdisk-unavailable"
ouiaId="bootdisk button unavailable"
component="button"
href="#"
tooltip={sprintf(
__('Boot disk download not available for %s architecture'),
options.architectureName
)}
tooltipProps={{ entryDelay: 0, exitDelay: 0 }}
to="#"
tooltipProps={{
content: sprintf(
__('Boot disk download not available for %s architecture'),
options.architectureName
),
entryDelay: 0,
exitDelay: 0,
}}
icon={<BanIcon />}
>
{__('Not available')}
Expand All @@ -85,9 +94,19 @@ const HostBootdiskButtons = () => {
}

return (
<DropdownGroup label={__('Boot disk')} key="bootdisk-group">
{isLoading ? <Loading showText={false} /> : content}
</DropdownGroup>
<>
<Divider component="li" />
<DropdownGroup
className="bootdisk-group-group"
label={__('Boot disk')}
key="bootdisk-group"
>
<DropdownList>
{isLoading ? <Loading showText={false} /> : content}
</DropdownList>
</DropdownGroup>
<Divider key="separator" />
</>
);
};

Expand Down
3 changes: 3 additions & 0 deletions webpack/src/extensions/host/HostBootdiskButtons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.bootdisk-group-group > h1{
margin: 0;
}