Fixes #37776 Improve available_space Check in foreman_maintain #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hey @sayan3296, this is the PR we were talking about |
ehelms
reviewed
Aug 30, 2024
ehelms
reviewed
Aug 30, 2024
Co-authored-by: Eric Helms <eric.d.helms@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of problem:
The / free-space check was included in foreman_maintain but it was from the perspective of yum not able to complete the package updates due to lack of disk space in /var/cache , under the assumption that it was residing under / itself.
Mostly people would have a seperate FS for /var or have a large enough / to work with. And those with separate /var partition may not even need 4 GB free space in /.
There are some scenarios where Check fails even when there is plenty of space to handle the yum transaction
How reproducible:
Always when / partition available space < 4096 and /var/ has enough partition
Is this issue a regression from an earlier version:
No
Actual behavior:
The space_available Check fails