Fixes #38730 - jobs wizard bottons are same size#1002
Merged
MariaAga merged 1 commit intotheforeman:masterfrom Sep 10, 2025
Merged
Fixes #38730 - jobs wizard bottons are same size#1002MariaAga merged 1 commit intotheforeman:masterfrom
MariaAga merged 1 commit intotheforeman:masterfrom
Conversation
kfamilonidis
changed the title
MariaAga
requested changes
Sep 9, 2025
Member
MariaAga
left a comment
MariaAga
left a comment
There was a problem hiding this comment.
The correct fix for this would be to move the Tooltip to not wrap the buttons, and use triggerRef instead of wrapping them. Read more here: https://v5-archive.patternfly.org/components/tooltip#tooltip
The bug is caused because some of the buttons have a div wrap and some dont, which effects the css
The buttons can be found here: webpack/JobWizard/Footer.js
webpack/JobWizard/JobWizard.scss
Outdated
Comment on lines
+148
to
+155
| .pf-v5-c-wizard__footer { | ||
| .pf-m-tertiary { | ||
| height: 35px; | ||
| } | ||
| > div button { | ||
| margin-right: 16px; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This goes against:
Use specific css selectors to avoid conflicts with other plugins or the core.
Revert "Fixes #38730 - jobs wizard bottons are same size" This reverts commit 7f8dee75bb05560e2fde3ebc83e8638e2ddeeb5f. Fixes #38730 - jobs wizard bottons are same size
kfamilonidis
force-pushed
the
fix-wizard-button
branch
from
1f89ab6 to
8a40d68
Compare
ofedoren
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Monitor -> Jobs -> Run Jobs -> all wizard steps footer buttons should be in same size